bugfix/AB#31384 - Total Paid Amount - Update payment status checks for display#2011
Merged
JamesPasta merged 1 commit intodevfrom Feb 20, 2026
Merged
bugfix/AB#31384 - Total Paid Amount - Update payment status checks for display#2011JamesPasta merged 1 commit intodevfrom
JamesPasta merged 1 commit intodevfrom
Conversation
…to use status constant
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors payment status checks to use type-safe constants and fixes a bug in the payment calculation logic. The PR replaces hardcoded "Fully Paid" string literals with the CasPaymentRequestStatus.FullyPaid constant across multiple components and services.
Changes:
- Replaced string literal "Fully Paid" with
CasPaymentRequestStatus.FullyPaidconstant for consistent payment status comparisons - Fixed bug in ApplicantSubmissionsViewComponent that was checking
Status == PaymentRequestStatus.Submittedinstead of properly checkingPaymentStatus == "Fully Paid"for calculating paid amounts - Added null/whitespace validation for PaymentStatus field before comparison
- Updated using directives to reference
Unity.Payments.Codesnamespace
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ApplicantSubmissionsViewComponent.cs | Fixed payment status check logic to properly use PaymentStatus field with FullyPaid constant instead of checking Status field; added null/whitespace checks |
| GrantApplicationAppService.cs | Replaced "Fully Paid" string literal with CasPaymentRequestStatus.FullyPaid constant; added null/whitespace validation; minor comment emoji cleanup |
| PaymentInfoViewComponent.cs | Replaced "Fully Paid" string literal with CasPaymentRequestStatus.FullyPaid constant for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This pull request refactors payment status checks to use type-safe constants and fixes a bug in the payment calculation logic. The PR replaces hardcoded "Fully Paid" string literals with the
CasPaymentRequestStatus.FullyPaidconstant across multiple components and services.In the PaymentRequests table, there is
"Payments"."PaymentRequests"."Status"and"Payments"."PaymentRequests"."PaymentStatus". There are cases where a payment request status can be"Submitted", but the payment status of that request is not"Fully Paid".Now "Total Paid Amount $" and "Total Paid" are based on
"Payments"."PaymentRequests"."PaymentStatus" = 'Fully Paid'instead of"Payments"."PaymentRequests"."Status" = 7 (Submitted).Changes:
Status == PaymentRequestStatus.Submittedinstead of properly checkingPaymentStatus == "Fully Paid"for calculating paid amountsCasPaymentRequestStatus.FullyPaidconstant for consistent payment status comparisonsUnity.Payments.CodesnamespaceReviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.