feature/AB#32037 - Compact Copilot Instructions#2120
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a compact, structured set of Copilot instructions for the Unity Grant Manager solution, including reusable “skills”, scoped instruction files, custom agent definitions, and a VS Code setting to drive commit message generation.
Changes:
- Adds
applications/Unity.GrantManager/.github/copilot-instructions.mdplus scoped instruction files under.github/instructions/(C#, EF Core, testing). - Adds skill reference docs under
.github/skills/(testing, EF Core, DDD, module structure, application layer). - Adds Copilot agent definition markdown files under
.github/agents/and a catalog in.github/AGENTS.md. - Adds
.vscode/settings.jsonto point Copilot commit message generation at.github/commit-message-instructions.md, and adds root-level.github/copilot-instructions.md.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| applications/Unity.GrantManager/.vscode/settings.json | Configures Copilot commit message generation to use a repo-provided instruction file. |
| applications/Unity.GrantManager/.github/skills/unity-testing/SKILL.md | Documents testing stack and conventions (xUnit/Shouldly/NSubstitute, ABP test base). |
| applications/Unity.GrantManager/.github/skills/unity-module-structure/SKILL.md | Documents ABP module layout and dependency direction rules. |
| applications/Unity.GrantManager/.github/skills/unity-ef-core/SKILL.md | Documents EF Core patterns, contexts, repositories, and migrations guidance. |
| applications/Unity.GrantManager/.github/skills/unity-domain-driven-design/SKILL.md | Documents DDD conventions for entities, aggregates, repos, services, events. |
| applications/Unity.GrantManager/.github/skills/unity-application-layer/SKILL.md | Documents application layer conventions (DTOs, mapping, authorization, errors). |
| applications/Unity.GrantManager/.github/instructions/testing.instructions.md | Adds scoped Copilot instructions for test code files. |
| applications/Unity.GrantManager/.github/instructions/efcore.instructions.md | Adds scoped Copilot instructions for EntityFrameworkCore code. |
| applications/Unity.GrantManager/.github/instructions/csharp.instructions.md | Adds scoped Copilot instructions for all C# files. |
| applications/Unity.GrantManager/.github/copilot-instructions.md | Provides consolidated project overview + pointers to skills/agents. |
| applications/Unity.GrantManager/.github/commit-message-instructions.md | Defines commit message format derived from branch name AB# ID. |
| applications/Unity.GrantManager/.github/agents/test-triage.agent.md | Adds a test failure triage agent definition. |
| applications/Unity.GrantManager/.github/agents/test-strategy.agent.md | Adds a test strategy/planning agent definition. |
| applications/Unity.GrantManager/.github/agents/pr-readiness.agent.md | Adds a pre-PR readiness/quality gate agent definition. |
| applications/Unity.GrantManager/.github/agents/permissions-localization-auditor.agent.md | Adds a permissions/localization compliance audit agent definition. |
| applications/Unity.GrantManager/.github/agents/feature-planner.agent.md | Adds a feature planning agent definition. |
| applications/Unity.GrantManager/.github/agents/efcore-migration-planner.agent.md | Adds an EF Core migration planning agent definition. |
| applications/Unity.GrantManager/.github/agents/ddd-modeler.agent.md | Adds a DDD modeling agent definition (currently has a broken skill reference). |
| applications/Unity.GrantManager/.github/agents/application-service-designer.agent.md | Adds an application service contract/design agent definition. |
| applications/Unity.GrantManager/.github/AGENTS.md | Adds an agent catalog for discoverability. |
| .github/copilot-instructions.md | Adds repo-root Copilot instructions and points to the app-specific instructions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Updated architecture rules for ABP layering and preferred usage, emphasizing separation of concerns and guidelines for new code.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Adds a compact, structured set of Copilot instructions for the Unity Grant Manager solution, including reusable “skills”, scoped instruction files, custom agent definitions, and a VS Code setting to drive commit message generation.
Changes:
applications/Unity.GrantManager/.github/copilot-instructions.mdplus scoped instruction files under.github/instructions/(C#, EF Core, testing)..github/skills/(testing, EF Core, DDD, module structure, application layer)..github/agents/and a catalog in.github/AGENTS.md..vscode/settings.jsonto point Copilot commit message generation at.github/commit-message-instructions.md, and adds root-level.github/copilot-instructions.md.Notes: