Skip to content

Feature/ab#31810 ai application analysis recommendations enhancements#2122

Merged
JamesPasta merged 5 commits into
devfrom
feature/AB#31810-AIApplicationAnalysisRecommendationsEnhancements
Mar 12, 2026
Merged

Feature/ab#31810 ai application analysis recommendations enhancements#2122
JamesPasta merged 5 commits into
devfrom
feature/AB#31810-AIApplicationAnalysisRecommendationsEnhancements

Conversation

@jacobwillsmith
Copy link
Copy Markdown
Contributor

Pull request overview

This pull request enhances AI Application Analysis so reviewers get a clearer high-level recommendation, explicit rationale, and a more stable review layout. It extends the analysis contract with a recommendation object and a dedicated nextSteps collection, then reshapes the UI around a fixed set of analysis sections instead of the older accordion-style presentation.

It also simplifies the hidden-item model by moving visibility state onto each analysis item, updates the analysis prompt/output contract to match the new structure, and keeps the AI Analysis tab aligned with reviewer workflow by surfacing a compact tab-level status indicator.

Changes:

  • Added recommendation and nextSteps to the application analysis contract
  • Moved analysis item visibility state to per-item hidden flags and renamed the UI/action vocabulary from dismiss/restore to hide/show
  • Updated analysis prompt templates and parsing/validation to support the new response shape
  • Reworked the AI Analysis tab into stable section cards for Recommendation, Errors, Warnings, Summary, and Next Steps
  • Added tab-level recommendation status signaling and simplified hidden-item rendering so hidden items stay inline within their original sections
  • Simplified legacy-style v0 prompt wording while keeping it operationally compatible with the current runtime contract

# Conflicts:
#	applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/GrantApplications/Details.cshtml
#	applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/GrantApplications/ai-analysis.js
@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 466
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@jacobwillsmith jacobwillsmith marked this pull request as ready for review March 12, 2026 15:21
@JamesPasta JamesPasta merged commit 1f10373 into dev Mar 12, 2026
22 checks passed
@JamesPasta JamesPasta deleted the feature/AB#31810-AIApplicationAnalysisRecommendationsEnhancements branch March 13, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants