bugfix/AB#29602-currency-formatting-payment-threshold#2141
Merged
DavidBrightBcGov merged 2 commits intoMar 17, 2026
Conversation
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a currency-masked “Approval Payment Threshold” input to the Payment Configuration UI to address AB#29602 and ensure the server receives an unformatted numeric value.
Changes:
- Added
jquery-maskMoneyto the PaymentConfiguration widget script bundle. - Updated PaymentConfiguration threshold input to use a currency-masked text field and send an unmasked value on save.
- Added a jQuery Validate normalizer for comma-stripping (currently placed in the AssessmentResults widget JS).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/PaymentConfiguration/PaymentConfigurationViewComponent.cs |
Adds jquery-maskMoney to the PaymentConfiguration script bundle. |
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/PaymentConfiguration/Default.js |
Sends unmasked threshold value to the save API; initializes currency masking. |
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/PaymentConfiguration/Default.cshtml |
Converts threshold input to a currency-masked text input and adds inline masking initialization. |
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/AssessmentResults/Default.js |
Adds a validation rule for #PaymentApprovalThreshold (but that element is not part of AssessmentResults). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
deleted the
bugfix/AB#29602-currency-formatting-payment-threshold
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#29602
Added payment threshold input with currency masking