bugfix/AB#29259-declining-required-amount#2143
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Assessment Results currency field handling by aligning the Approved Amount field name with the Approval view model and updating currency masking to accept zero values.
Changes:
- Updated the currency-field name list to treat
ApprovalView.ApprovedAmountas a currency/number field. - Updated maskMoney initialization for
.unity-currency-inputto allow zero values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/AssessmentResults/Default.js | Updates currency field detection for Approved Amount (now under ApprovalView). |
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/AssessmentResults/Default.cshtml | Changes currency input masking options to allow zero values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
approved these changes
Mar 18, 2026
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#29259
Unable to reproduce bug, however found 'ApprovedAmount' was not being properly error checked for null. Also now permit zeros in the RequestedAmount, TotalProjectBudget, RecommendedAmount and RecommendedAmount