bugfix/AB#29602-payment-threshold-format-allow-empty#2150
Merged
DavidBrightBcGov merged 4 commits intoMar 20, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Payment Configuration widget’s currency masking to allow the payment threshold field to remain empty/null (instead of forcing a formatted value), aligning the UI behavior with the backend’s nullable threshold semantics.
Changes:
- Moved initial currency masking logic out of the
.cshtmland into the component’sDefault.js. - Added focus/blur handlers to destroy/reinitialize maskMoney so empty values can be left blank.
- Applied masking on load only when an input has a non-empty value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/PaymentConfiguration/Default.js | Reworked maskMoney initialization and added focus/blur logic to support empty/null currency input. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/PaymentConfiguration/Default.cshtml | Removed inline <script> masking initialization now handled by Default.js. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
deleted the
bugfix/AB#29602-payment-threshold-format-allow-empty
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#29602
Had to rebuild the maskMoney logic to permit empty/null input as the field uses null functionality. maskMoney allowEmpty=true does not function