Skip to content

bugfix/AB#31673 - Update payment action button states and reset logic#2177

Merged
JamesPasta merged 2 commits into
devfrom
bugfix/AB#31673-payment-action-button-state
Mar 26, 2026
Merged

bugfix/AB#31673 - Update payment action button states and reset logic#2177
JamesPasta merged 2 commits into
devfrom
bugfix/AB#31673-payment-action-button-state

Conversation

@plavoie-BC
Copy link
Copy Markdown
Contributor

@plavoie-BC plavoie-BC commented Mar 26, 2026

Pull request overview

Updates the Payments UI selection/reset flows so action buttons reflect current selection state and are reset/disabled after bulk actions (tagging, status check, approve/decline) to prevent stale selections driving incorrect actions.

Changes:

  • Trigger action button state recalculation after payment tags modal completes.
  • Add data-selector="batch-payment-table-actions" to the “Check Status” DataTable button so the shared action bar logic can disable it when nothing is selected.
  • Expand “reset” logic after status check / modal result / refresh events (disable buttons, clear selection state, publish reset events).

@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 565
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Payments UI selection/reset flows so action buttons reflect current selection state and are reset/disabled after bulk actions (tagging, status check, approve/decline) to prevent stale selections driving incorrect actions.

Changes:

  • Trigger action button state recalculation after payment tags modal completes.
  • Add data-selector="batch-payment-table-actions" to the “Check Status” DataTable button so the shared action bar logic can disable it when nothing is selected.
  • Expand “reset” logic after status check / modal result / refresh events (disable buttons, clear selection state, publish reset events).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
applications/Unity.GrantManager/modules/Unity.Payments/src/Unity.Payments.Web/Views/Shared/Components/PaymentActionBar/Default.js Ensures action bar buttons are recalculated after tag updates (and reveals an existing .action-bar class toggle issue).
applications/Unity.GrantManager/modules/Unity.Payments/src/Unity.Payments.Web/Pages/PaymentRequests/Index.js Adds selector attribute to “Check Status” and extends/reset button+selection state handling across multiple flows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@plavoie-BC plavoie-BC requested a review from JamesPasta March 26, 2026 20:46
@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 565
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@plavoie-BC plavoie-BC marked this pull request as ready for review March 26, 2026 20:54
@JamesPasta JamesPasta merged commit 65ffa8e into dev Mar 26, 2026
22 checks passed
@JamesPasta JamesPasta deleted the bugfix/AB#31673-payment-action-button-state branch March 26, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants