bugfix/AB#31673 - Update payment action button states and reset logic#2177
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Payments UI selection/reset flows so action buttons reflect current selection state and are reset/disabled after bulk actions (tagging, status check, approve/decline) to prevent stale selections driving incorrect actions.
Changes:
- Trigger action button state recalculation after payment tags modal completes.
- Add
data-selector="batch-payment-table-actions"to the “Check Status” DataTable button so the shared action bar logic can disable it when nothing is selected. - Expand “reset” logic after status check / modal result / refresh events (disable buttons, clear selection state, publish reset events).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| applications/Unity.GrantManager/modules/Unity.Payments/src/Unity.Payments.Web/Views/Shared/Components/PaymentActionBar/Default.js | Ensures action bar buttons are recalculated after tag updates (and reveals an existing .action-bar class toggle issue). |
| applications/Unity.GrantManager/modules/Unity.Payments/src/Unity.Payments.Web/Pages/PaymentRequests/Index.js | Adds selector attribute to “Check Status” and extends/reset button+selection state handling across multiple flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JamesPasta
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Updates the Payments UI selection/reset flows so action buttons reflect current selection state and are reset/disabled after bulk actions (tagging, status check, approve/decline) to prevent stale selections driving incorrect actions.
Changes:
data-selector="batch-payment-table-actions"to the “Check Status” DataTable button so the shared action bar logic can disable it when nothing is selected.