Skip to content

bugfix/AB#32347 and bugfix/AB#31022 - Application Style Fixes#2183

Merged
JamesPasta merged 4 commits into
devfrom
bugfix/AB#32347-application-style-fixes
Mar 27, 2026
Merged

bugfix/AB#32347 and bugfix/AB#31022 - Application Style Fixes#2183
JamesPasta merged 4 commits into
devfrom
bugfix/AB#32347-application-style-fixes

Conversation

@plavoie-BC
Copy link
Copy Markdown
Contributor

@plavoie-BC plavoie-BC commented Mar 27, 2026

This pull request contains fixes for:

  • [AB#32347] Fix DataTable button default styling
  • [AB#31022] Fix email notification table x-overflow cutoff

Pull request overview

This PR addresses two UI regressions related to DataTables in Unity.GrantManager: restoring consistent default button styling and preventing the Email History table from horizontally overflowing/cutting off content.

Changes:

  • Removes component-level DataTables Buttons default overrides from ReviewList.js.
  • Introduces/updates global DataTables Buttons default DOM styling in UX2 table-utils.js.
  • Updates Email History widget to disable horizontal scrolling and enforce a fixed, wrapping layout via JS column sizing + targeted CSS.

@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 565
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses two UI regressions related to DataTables in Unity.GrantManager: restoring consistent default button styling and preventing the Email History table from horizontally overflowing/cutting off content.

Changes:

  • Removes component-level DataTables Buttons default overrides from ReviewList.js.
  • Introduces/updates global DataTables Buttons default DOM styling in UX2 table-utils.js.
  • Updates Email History widget to disable horizontal scrolling and enforce a fixed, wrapping layout via JS column sizing + targeted CSS.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/ReviewList/ReviewList.js Removes local DataTables Buttons default styling so button styling can be centralized.
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/EmailHistoryWidget/EmailHistory.css Reworks table wrapper/table/cell styling to avoid horizontal overflow and enforce wrapping/fixed layout.
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/EmailHistoryWidget/Default.js Disables scrollX and adjusts column widths to fit within the container.
applications/Unity.GrantManager/modules/Unity.Theme.UX2/src/Unity.Theme.UX2/wwwroot/themes/ux2/table-utils.js Sets global DataTables Buttons defaults (className + liner tag handling).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@plavoie-BC plavoie-BC requested a review from JamesPasta March 27, 2026 18:02
@plavoie-BC plavoie-BC marked this pull request as ready for review March 27, 2026 18:02
@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 565
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@JamesPasta JamesPasta merged commit ab6cc54 into dev Mar 27, 2026
22 checks passed
@JamesPasta JamesPasta deleted the bugfix/AB#32347-application-style-fixes branch March 27, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants