Feature/ab#32491 portal address updates#2252
Merged
Conversation
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Grants Portal address command support (create/delete) and improves primary-address tracking consistency across handlers, tests, and documentation.
Changes:
- Introduces
ADDRESS_CREATE_COMMANDandADDRESS_DELETE_COMMANDhandlers, DTOs, DI registration, and tests. - Updates address primary-flag behavior to demote sibling addresses when promoting a new primary (edit/create/set-primary paths).
- Centralizes address extra-property keys via
AddressExtraPropertyNamesand updates docs/data provider accordingly.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| documentation/applicant-portal/grants-portal-rabbitmq-integration.md | Documents new address commands and payload shape; updates handler registrations. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Application.Tests/GrantsPortal/AddressEditHandlerTests.cs | Adds coverage for primary promotion/demotion behavior during address edits. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Application.Tests/GrantsPortal/AddressDeleteHandlerTests.cs | Adds tests for idempotent address delete behavior. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Application.Tests/GrantsPortal/AddressCreateHandlerTests.cs | Adds tests for address creation, idempotency, mapping, and primary demotion. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Domain.Shared/GrantApplications/AddressExtraPropertyNames.cs | Defines constants for isPrimary / profileId extra-property keys. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/GrantsPortal/Messages/Commands/AddressCreateData.cs | Adds command payload DTO for address creation (includes applicantId). |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/GrantsPortal/Handlers/AddressSetPrimaryHandler.cs | Uses extra-property constants and continues to demote sibling addresses. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/GrantsPortal/Handlers/AddressEditHandler.cs | Syncs isPrimary on edit and demotes sibling primaries when promoting. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/GrantsPortal/Handlers/AddressDeleteHandler.cs | Implements idempotent delete handler for addresses. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/GrantsPortal/Handlers/AddressCreateHandler.cs | Implements create handler with idempotency and sibling-primary demotion. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/GrantManagerApplicationModule.cs | Registers new handlers and inbox adapters in DI. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/ApplicantProfile/AddressInfoDataProvider.cs | Reads isPrimary using the centralized extra-property constant. |
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.