Bugfix/ab#32704 manual generate scoring no longer creates an ai assessment row#2324
Merged
JamesPasta merged 4 commits intoApr 22, 2026
Conversation
|
jacobwillsmith
approved these changes
Apr 22, 2026
JamesPasta
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



ApplicationAIScoringGeneratedEventwas being published immediately afterRegenerateAndSaveAsync, before the current Unit of Work committed. The event handler would then query for the AI Assessment row that hadn't been persisted yet. Fixed by deferring the event publish toUnitOfWorkManager.Current.OnCompleted(), ensuring the row is in the database before the handler runs.GenerateApplicationScoringJob,GenerateApplicationAnalysisJob,GenerateAttachmentSummaryJob) and their args classes, and removed the correspondingQueueAttachmentSummariesAsync,QueueApplicationAnalysisAsync,QueueApplicationScoringAsyncmethods fromIApplicationAIGenerationQueueand its implementation. OnlyQueueApplicationPipelineAsyncremains.AbpAuthorizationExceptioninRunApplicationAIPipelineJob(AB#32301): Background jobs run without an authenticated user, so calling class-level[Authorize]-decorated app service methods always fails. Added internal-onlyForPipelinevariants ([AllowAnonymous]+[RemoteService(IsEnabled = false)]) to all three AI app services. The job now calls these instead. Public HTTP-facing methods remain fully protected.