Skip to content

Feature/ab#32299 split openaiservice responsibilities#2326

Merged
JamesPasta merged 2 commits into
devfrom
feature/AB#32299-split-openaiservice-responsibilities
Apr 22, 2026
Merged

Feature/ab#32299 split openaiservice responsibilities#2326
JamesPasta merged 2 commits into
devfrom
feature/AB#32299-split-openaiservice-responsibilities

Conversation

@jacobwillsmith
Copy link
Copy Markdown
Contributor

Pull request overview

Simplified the OpenAI configuration resolver to read the normal nested Azure:... keys directly. This removes the explicit compatibility constants and relies on standard .NET configuration binding for environment variables and appsettings values.

Changes:

  • Removed the explicit OpenAI env-var compatibility constants from the resolver
  • Kept API key and endpoint resolution on the nested Azure:OpenAI:... config keys
  • Preserved the legacy Azure:OpenAI:ApiUrl fallback path
  • Left the rest of the OpenAI runtime behavior unchanged

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 620
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@jacobwillsmith jacobwillsmith marked this pull request as ready for review April 22, 2026 15:38
@JamesPasta JamesPasta merged commit add43b9 into dev Apr 22, 2026
25 checks passed
@JamesPasta JamesPasta deleted the feature/AB#32299-split-openaiservice-responsibilities branch April 22, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants