feature/AB#31755 - Remove jsPDF dependency and update outdated NPM packages#2347
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the jsPDF dependency from the Unity.GrantManager web project and refreshes several front-end NPM packages to newer versions.
Changes:
- Remove
jspdffrompackage.jsonand stop mapping/loading its assets. - Upgrade selected dependencies (notably
formiojs,datatables.net-bs5,dompurify,handlebars,tinymce) and updateyarn.lockaccordingly. - Update the Grant Application Details page to no longer load the jsPDF script.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/yarn.lock | Updates resolved dependency graph; jsPDF removed; several packages updated. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/package.json | Removes jsPDF and bumps a few dependency versions. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/abp.resourcemapping.js | Removes jsPDF resource mapping. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/GrantApplications/Details.cshtml | Stops loading jsPDF on the details page. |
Comments suppressed due to low confidence (1)
applications/Unity.GrantManager/src/Unity.GrantManager.Web/package.json:14
datatables.net-bs5is bumped to~2.3.8, butyarn.lockstill resolves other DataTables consumers (e.g.,datatables.net-buttons-bs5viadatatables.net-bs5 "^2") to2.3.7, which results in multiple DataTables versions being installed. This can cause plugin/extension mismatches at runtime and increases bundle size; consider running a full upgrade/dedupe so alldatatables.net*packages resolve to the same2.3.8version (or pin viaresolutions).
"datatables.net-bs5": "~2.3.8",
"datatables.net-buttons-bs5": "~3.2.6",
"datatables.net-colreorder": "~2.1.1",
"datatables.net-colreorder-bs5": "~2.1.1",
"datatables.net-fixedheader": "~4.0.6",
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
…pdates-jspdf-remove
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
1 similar comment
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
|
JamesPasta
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR removes the jsPDF dependency from the Unity.GrantManager web project and refreshes several front-end NPM packages to newer versions.
Changes:
jspdfandhtml2canvasfrompackage.jsonand stop mapping/loading its assets.formiojs,datatables.net-bs5,dompurify,handlebars,tinymce) and updateyarn.lockaccordingly.Reviewed changes
Pacakge updates