Skip to content

Feature/ab#32841 cas payment quality receiver #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesPasta merged 2 commits into from
May 26, 2026
Merged

Feature/ab#32841 cas payment quality receiver #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9098487
feature/AB#32841-AddQRandPaymentDescription-Fixes
JamesPasta May 26, 2026
99e2102
feature/AB#32841-AddQRandPaymentDescription-Fixes
JamesPasta May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 37 additions & 39 deletions ...r/modules/Unity.Payments/src/Unity.Payments.Application/Domain/Services/InvoiceManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,50 +63,48 @@ public async Task UpdatePaymentRequestWithInvoiceAsync(Guid paymentRequestId, In
try
{
// Each attempt must have a fresh UoW
using (var uow = unitOfWorkManager.Begin())
{
// Load with tracking
var paymentRequest = await paymentRequestRepository.GetAsync(paymentRequestId);

if (paymentRequest == null)
{
Logger.LogWarning("PaymentRequest {Id} not found. Skipping update.", paymentRequestId);
return;
}

// Idempotency: do not re-process
if (paymentRequest.InvoiceStatus == CasPaymentRequestStatus.SentToCas)
{
Logger.LogInformation(
"PaymentRequest {Id} already invoiced. Skipping update.",
paymentRequestId
);
return;
}

// Apply CAS response info
paymentRequest.SetCasHttpStatusCode((int)invoiceResponse.CASHttpStatusCode);
paymentRequest.SetCasResponse(invoiceResponse.CASReturnedMessages);

// Set status
paymentRequest.SetInvoiceStatus(
invoiceResponse.IsSuccess()
? CasPaymentRequestStatus.SentToCas
: CasPaymentRequestStatus.ErrorFromCas
);
using var uow = unitOfWorkManager.Begin();
// Load with tracking
var paymentRequest = await paymentRequestRepository.GetAsync(paymentRequestId);

await paymentRequestRepository.UpdateAsync(paymentRequest, autoSave: false);

// Commit this attempt
await uow.CompleteAsync();
if (paymentRequest == null)
{
Logger.LogWarning("PaymentRequest {Id} not found. Skipping update.", paymentRequestId);
return;
}

// Idempotency: do not re-process
if (paymentRequest.InvoiceStatus == CasPaymentRequestStatus.SentToCas)
{
Logger.LogInformation(
"PaymentRequest {Id} updated successfully on attempt {Attempt}.",
paymentRequestId,
attempt
"PaymentRequest {Id} already invoiced. Skipping update.",
paymentRequestId
);
return; // success
return;
}

// Apply CAS response info
paymentRequest.SetCasHttpStatusCode((int)invoiceResponse.CASHttpStatusCode);
paymentRequest.SetCasResponse(invoiceResponse.CASReturnedMessages);

// Set status
paymentRequest.SetInvoiceStatus(
invoiceResponse.IsSuccess()
? CasPaymentRequestStatus.SentToCas
: CasPaymentRequestStatus.ErrorFromCas
);

await paymentRequestRepository.UpdateAsync(paymentRequest, autoSave: false);

// Commit this attempt
await uow.CompleteAsync();

Logger.LogInformation(
"PaymentRequest {Id} updated successfully on attempt {Attempt}.",
paymentRequestId,
attempt
);
return; // success
}
catch (Exception ex) when (
ex is AbpDbConcurrencyException ||
Expand Down
4 changes: 2 additions & 2 deletions ...c/Unity.Payments.Application/EntityFrameworkCore/Repositories/PaymentRequestRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ namespace Unity.Payments.Repositories
{
public class PaymentRequestRepository : EfCoreRepository<PaymentsDbContext, PaymentRequest, Guid>, IPaymentRequestRepository
{
private List<string> ReCheckStatusList { get; set; } = new List<string>();
private List<string> FailedStatusList { get; set; } = new List<string>();
private List<string> ReCheckStatusList { get; set; } = [];
private List<string> FailedStatusList { get; set; } = [];

public PaymentRequestRepository(IDbContextProvider<PaymentsDbContext> dbContextProvider) : base(dbContextProvider)
{
Expand Down
Loading
Loading