Skip to content

bugfix/AB#32785 - Fix tag menu slider overflow and height issues#2503

Merged
JamesPasta merged 3 commits into
devfrom
bugfix/AB#32785-tag-menu-slider
May 28, 2026
Merged

bugfix/AB#32785 - Fix tag menu slider overflow and height issues#2503
JamesPasta merged 3 commits into
devfrom
bugfix/AB#32785-tag-menu-slider

Conversation

@plavoie-BC
Copy link
Copy Markdown
Contributor

@plavoie-BC plavoie-BC commented May 28, 2026

Pull request overview

This PR addresses layout overflow issues in the Configuration Management Tags pane by removing DataTables horizontal scroll behavior and allowing the Tags section/page container to grow naturally.

Changes:

  • Removed scrollCollapse and scrollX from the "global tags" DataTable configuration.
  • Added Tags-specific CSS overrides to prevent DataTables/container height clipping.
  • Included incidental yarn.lock descriptor reordering, flagged as a nit.

Reviewed changes

File Description
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Settings/TagManagement/TagManagement.js Updates the Tags DataTable configuration to avoid DataTables-managed horizontal scrolling.
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/ConfigurationManagement/Index.css Adds scoped layout overrides so the Tags pane and app container can expand instead of clipping content.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses layout overflow issues in the Configuration Management Tags pane by removing DataTables horizontal scroll behavior and allowing the Tags section/page container to grow naturally.

Changes:

  • Removed scrollCollapse and scrollX from the global tags DataTable setup.
  • Added Tags-specific CSS overrides to prevent DataTables/container height clipping.
  • Included incidental yarn.lock descriptor reordering, flagged as a nit.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Settings/TagManagement/TagManagement.js Updates the Tags DataTable configuration to avoid DataTables-managed horizontal scrolling.
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/ConfigurationManagement/Index.css Adds scoped layout overrides so the Tags pane and app container can expand instead of clipping content.
applications/Unity.GrantManager/src/Unity.GrantManager.Web/yarn.lock Reorders/removes lockfile descriptors without dependency version changes.

@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 752
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 752
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@plavoie-BC plavoie-BC requested a review from JamesPasta May 28, 2026 17:56
@plavoie-BC plavoie-BC marked this pull request as ready for review May 28, 2026 17:58
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 752
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

@JamesPasta JamesPasta merged commit 025a1de into dev May 28, 2026
25 checks passed
@JamesPasta JamesPasta deleted the bugfix/AB#32785-tag-menu-slider branch May 28, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants