bugfix/AB#32773 - Fix Payment and Applications Tag Modal Permissions#2506
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes tag modal permission collisions between application and payment tagging by separating the payment tag input global from the application tag input global.
Changes:
- Renames the payment tag input constructor usage to
PaymentTagsInput. - Exposes application and payment tag inputs under distinct
globalThisnames. - Tweaks tag/input internals and a
data-touchedassignment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
Views/Shared/Components/ActionBar/Default.js |
Updates data-touched assignment for user tags input. |
Pages/ApplicationTags/ApplicationTags.js |
Keeps application tag input global and refactors internal instance references. |
modules/Unity.Payments/.../PaymentActionBar/Default.js |
Instantiates the renamed payment tag input constructor. |
modules/Unity.Payments/.../PaymentTags/PaymentTags.js |
Exposes payment tag input under PaymentTagsInput and refactors internal instance references. |
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
|
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR fixes tag modal permission collisions between application and payment tagging by separating the payment tag input global from the application tag input global.
Changes:
PaymentTagsInput.globalThisnames.data-touchedassignment.Reviewed changes
Views/Shared/Components/ActionBar/Default.jsdata-touchedassignment for user tags input.Pages/ApplicationTags/ApplicationTags.jsmodules/Unity.Payments/.../PaymentActionBar/Default.jsmodules/Unity.Payments/.../PaymentTags/PaymentTags.jsPaymentTagsInputand refactors internal instance references.