Skip to content

feature/AB#26877 - Notifications Settings Management #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jimmyPasta merged 19 commits into from
Dec 11, 2024
Merged

feature/AB#26877 - Notifications Settings Management #930

jimmyPasta merged 19 commits into from
Dec 11, 2024

Conversation

@plavoie-BC
Copy link
Contributor

@plavoie-BC plavoie-BC commented Dec 11, 2024 •
edited
Loading

  • Configure settings management interface for Notifications module
  • Add DefaultFromAddress setting and integrate into places where configuration was previously used
  • Remove default TimeZone and Emailing settings management UI (AB#27129)

@plavoie-BC
AB#26877 - Add Notifications Settings and Management Interface
30ce563
@plavoie-BC
UI Tag Helper Bugfix
0350e20
@plavoie-BC
Change notification settings form
3abe879
@plavoie-BC
Merge remote-tracking branch 'origin/dev' into feature/AB#26877-email…
304af23 
…-settings-management
@plavoie-BC
Merge branch 'dev' into feature/AB#26877-email-settings-management
d184907
@plavoie-BC
Add null handling for externalUserLookupServiceProvider bugfixes
bd81c4f
@plavoie-BC
Change from email configuration to notificaiton setting provider for …
a193a65 
…DefaultFromAddress
@plavoie-BC
Add feature gate for Notifications Setting Page
f587f50
@plavoie-BC
Add Notifications setting permissions
7e665b0
@plavoie-BC
SonarQube fixes
85c347d
@plavoie-BC
Add Notification Setting Management UI JavaScript
830300f
@plavoie-BC
Fix Notification Settings Virtual File System references
647a21b
@plavoie-BC
Add email address validation
dd2b88d
@plavoie-BC
AB#27129 - Remove default TimeZone and Emailing settings management UI
0a211eb
@plavoie-BC
Update settings topbar user and feature requirements
0d51fa4
@plavoie-BC
Remove DefaultFromDisplayName setting property
9ea2af7
@plavoie-BC plavoie-BC changed the title feature/AB#26877 - Notifications Settings Management (DRAFT) feature/AB#26877 - Notifications Settings Management Dec 11, 2024
@plavoie-BC plavoie-BC changed the title (DRAFT) feature/AB#26877 - Notifications Settings Management feature/AB#26877 - Notifications Settings Management Dec 11, 2024
@plavoie-BC plavoie-BC marked this pull request as ready for review December 11, 2024 18:25
jimmyPasta
jimmyPasta approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@jimmyPasta jimmyPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to confirm with the business if NoReply or Unity is used in Email from

NoReply@gov.bc.ca

@jimmyPasta jimmyPasta merged commit 189e694 into dev Dec 11, 2024
@plavoie-BC plavoie-BC deleted the feature/AB#26877-email-settings-management branch December 11, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jimmyPasta jimmyPasta jimmyPasta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@plavoie-BC @jimmyPasta