Error toasts: show HTTP response detail + don't auto-close#235
Merged
Error toasts: show HTTP response detail + don't auto-close#235
Conversation
dffd300 to
e0a7e58
Compare
e0a7e58 to
222ad66
Compare
TimCsaky
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The detailed COMS error response message (specifically, the
detailfield) is now displayed in the toast body instead. Previously, only the HTTP response code and a genericAxiosErrormessage is displayed.Example: updating a bucket using invalid S3 credentials
Before:
After:
Also, error notifications no longer disappear automatically; they must be closed manually instead.
This should make it easier for users to diagnose basic errors, without having to reach out to us every time.
SHOWCASE-3941
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
If the error isn't coming from the COMS API (or if COMS fails to return a properly-formatted error response as per the API spec), the toast message will fallback to the raw error itself, as was the case previously.