Fix: BucketList folders only accessible via IDP perms reverting to dummy folders on folder add/delete#251
Merged
Conversation
This fixes a minor BucketList bug, where buckets only accessible via IDP perms would revert to dummy folders when folders are added/removed by the user. This is because fetchBuckets() does not use the same logic to populate dummy folders with ones that may be accessible via IDP perms. Also: in bucketStore, rename permResponse to userPermResponse for clarity (and to reflect difference between user perms and IDP perms).
Coverage Report (Application)
|
Coverage Report (Frontend)
|
TimCsaky
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug on the "My Files" page, where folders only visible due to IDP permissions revert to dummy folders whenever a folder is added or removed.
These folders start out as dummy folders, but are substituted with fully-fledged folders (as if the user has only
READpermissions on them) duringBucketList.onMounted. This substitution logic wasn't replicated whenever a user added/removed a folder, so the bucket list refresh it triggers reverted those intermediate folders to dummy folders.This PR extracts that substitution logic into a helper function, which is now also called whenever folders are added/removed by the user.
Also: in
bucketStore.ts,permResponsehas been renameduserPermResponsefor clarity, and to reflect the difference between user permissions and IDP permissions.https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-4365
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
N/A