Button: add visible pressed state#635
Merged
mkernohanbc merged 5 commits intomainfrom Feb 20, 2026
Merged
Conversation
mkernohanbc
added
the
Components
Philip-Cheung
approved these changes
Feb 18, 2026
ty2k
requested changes
Feb 20, 2026
Contributor
ty2k
left a comment
ty2k
left a comment
There was a problem hiding this comment.
Everything looks great visually, but I think we should avoid replacing those pixel values unless the tokens we're using are genuinely meant for that purpose.
This reverts commit ba9b3c0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issues identified by @ty2k in #632, by adding additional styling when a button is pressed (using the
[data-pressed]attribute).ba9b3c0 also does some cleanup to replace various hardcoded values with tokenized ones.
Primary Button Large is pressed:
Secondary Button Medium is pressed:
Primary Button Medium is pressed:
