Skip to content

31674 - Remove CustodialOffice from API Specs and Postman Collection#248

Merged
argush3 merged 2 commits intobcgov:mainfrom
meawong:31674-Remove-Custodial-Office-from-Spec
Jan 5, 2026
Merged

31674 - Remove CustodialOffice from API Specs and Postman Collection#248
argush3 merged 2 commits intobcgov:mainfrom
meawong:31674-Remove-Custodial-Office-from-Spec

Conversation

@meawong
Copy link
Copy Markdown
Contributor

@meawong meawong commented Dec 31, 2025

Issue #: /bcgov/entity#31674

Postman Collection:

  • Remove CustodialOffice references

API Specs:

  • Remove CustodialOffice references
  • Update parties description to clarify that a custodian is required for a VD
image

@argush3
Copy link
Copy Markdown
Collaborator

argush3 commented Jan 5, 2026

/gcbrun

@bcregistry-sre
Copy link
Copy Markdown
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-248-4v8r0uop.web.app

Comment thread web/site/public/br/business-spec.yaml Outdated
parties:
type: array
description: Can be the company directors or applicant of the filing. This field is required for voluntary dissolution filings.
description: Can be the company directors, Custodian or applicant of the filing. This field is required for voluntary dissolution filings, in which case a Custodian must be included.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only custodian is valid for corps and completing party is valid for firms https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/services/filings/validations/dissolution.py#L177

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custodian is valid for coops too i guess

@vysakh-menon-aot
Copy link
Copy Markdown

/gcbrun

1 similar comment
@argush3
Copy link
Copy Markdown
Collaborator

argush3 commented Jan 5, 2026

/gcbrun

@bcregistry-sre
Copy link
Copy Markdown
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-248-4v8r0uop.web.app

@argush3 argush3 merged commit 1ceb354 into bcgov:main Jan 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants