Business API: (Amalgamation Application - Regular) Add Minimum Share Classes Validation

[meawong]

Description:

As an API user posting a regular amalgamation application, I want to get appropriate validation errors if I submit a share structure with no share classes, so that the resulting business is never created without an authorized share structure.

On the frontend, at least one share class is required for regular amalgamations — submission is blocked if none are present. The backend allows an empty array to be posted for share classes.

QA Notes

• Ensure regression of regular amalgamation application through the frontend — at least one share class continues to be required
• Posting a regular amalgamation application with at least one valid share class through the API works as expected
• Posting a regular amalgamation application with shareStructure: { shareClasses: [] } causes the API to return an appropriate error

[mruff-aeq]

made progress on this. i was learning how to use the QA postman collection provided by @vishnup0422

should finish this soon

[mruff-aeq]

@gunanagar @rsagpariya
this type of ticket is different, when it goes to test, you need to confirm via postman you get a 400 error
@mstanton1 can you advise if this type of ticket is to QA tested?

[mstanton1]

@mruff-aeq yes, this ticket would be QA tested via Postman.

In terms of QA, sometimes we can avoid tackling a back-end ticket like this if we are making the change in our UI and it pulls from the back-end. In those cases we could test as a whole when the UI work is done, which typically follows the API work. In this case the UI is functioning but we have misalignment with the back-end so it's only back-end work and we need QA.