29756 add missing insert on gcp migration #3665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| document.file_key = dissolution_filing.get("affidavitFileKey") | ||
| document.business_id = business.id | ||
| document.filing_id = filing.id | ||
| business.documents.append(document) |
Collaborator
Author
There was a problem hiding this comment.
This is required. report.py depend on this
| document.file_key = cooperative_obj.get("memorandumFileKey") | ||
| document.business_id = business.id | ||
| document.filing_id = filing.id | ||
| business.documents.append(document) |
Collaborator
Author
There was a problem hiding this comment.
This is required. report.py depend on this
argush3
approved these changes
Jul 24, 2025
Collaborator
Author
|
@thorwolpert any idea why the unit testing ci running for ever? I remember you mentioned it should be faster when the gcp migration was done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#29756
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).