Skip to content

Conversation

@thorwolpert
Copy link
Collaborator

Issue #: /bcgov/entity#29785

Description of changes:

  • update validator to allow BCBCA types
  • add tests for the new business types and document combinations

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Copy link
Collaborator

@kialj876 kialj876 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thorwolpert thorwolpert merged commit 90a82cb into bcgov:main Jul 25, 2025
6 of 9 checks passed
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.98%. Comparing base (4a6e4e4) to head (594fda8).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...gal_api/services/business/validations/validator.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3668      +/-   ##
==========================================
- Coverage   75.99%   75.98%   -0.01%     
==========================================
  Files         213      213              
  Lines       14428    14430       +2     
  Branches     2483     2485       +2     
==========================================
+ Hits        10964    10965       +1     
- Misses       2768     2769       +1     
  Partials      696      696              
Flag Coverage Δ
legalapi 75.98% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gal_api/services/business/validations/validator.py 88.88% <75.00%> (-1.12%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants