Skip to content

Conversation

@meawong
Copy link
Collaborator

@meawong meawong commented Jul 28, 2025

Issue #: /bcgov/entity#29716

Description of changes:

  • Add new registrar signature images
  • Add new entry in registrar_info

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@meawong meawong self-assigned this Jul 28, 2025
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.98%. Comparing base (594fda8) to head (d7a67ec).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...gal_api/services/business/validations/validator.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3671      +/-   ##
==========================================
- Coverage   75.98%   75.98%   -0.01%     
==========================================
  Files         213      213              
  Lines       14430    14430              
  Branches     2485     2485              
==========================================
- Hits        10965    10964       -1     
  Misses       2769     2769              
- Partials      696      697       +1     
Flag Coverage Δ
legalapi 75.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
legal-api/src/legal_api/reports/registrar_meta.py 100.00% <ø> (ø)
...gal_api/services/business/validations/validator.py 88.88% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@meawong meawong requested a review from vysakh-menon-aot July 28, 2025 18:53
@vysakh-menon-aot
Copy link
Collaborator

Need update here as well

https://github.com/bcgov/lear/blob/main/gcp-jobs/furnishings/src/furnishings/services/reports/registrar_meta.py

@vysakh-menon-aot vysakh-menon-aot requested a review from argush3 July 28, 2025 21:30
@meawong meawong merged commit b26f8e9 into bcgov:main Jul 28, 2025
11 of 13 checks passed
@meawong meawong deleted the 29716-Add-New-Registrar-Signature branch July 29, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants