Skip to content

Conversation

@meawong
Copy link
Collaborator

@meawong meawong commented Aug 5, 2025

Issue #: /bcgov/entity#29716

Description of changes:

  • Update Registrar Signature date to Aug 12
  • Update API version

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@meawong meawong self-assigned this Aug 5, 2025
@codecov
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.05%. Comparing base (594fda8) to head (9b0dec1).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3687      +/-   ##
==========================================
- Coverage   75.98%   67.05%   -8.94%     
==========================================
  Files         213      252      +39     
  Lines       14430    17906    +3476     
  Branches     2485     2487       +2     
==========================================
+ Hits        10965    12006    +1041     
- Misses       2769     5202    +2433     
- Partials      696      698       +2     
Flag Coverage Δ
colinapi 29.90% <100.00%> (?)
legalapi 75.98% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
colin-api/src/colin_api/version.py 100.00% <100.00%> (ø)
legal-api/src/legal_api/reports/registrar_meta.py 100.00% <ø> (ø)
legal-api/src/legal_api/version.py 100.00% <100.00%> (ø)

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Vysakh, I asked Megan to update the 2 version files just to keep everything in sync.

@severinbeauvais severinbeauvais merged commit 601390a into bcgov:main Aug 5, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants