Skip to content

Conversation

@vysakh-menon-aot
Copy link
Collaborator

Issue #: /bcgov/entity#29953

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@vysakh-menon-aot vysakh-menon-aot self-assigned this Aug 14, 2025
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.11%. Comparing base (594fda8) to head (92e9524).
⚠️ Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
colin-api/src/colin_api/models/filing.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3705      +/-   ##
==========================================
- Coverage   75.98%   67.11%   -8.88%     
==========================================
  Files         213      251      +38     
  Lines       14430    17888    +3458     
  Branches     2485     2482       -3     
==========================================
+ Hits        10965    12005    +1040     
- Misses       2769     5185    +2416     
- Partials      696      698       +2     
Flag Coverage Δ
colinapi 29.93% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
colin-api/src/colin_api/models/filing.py 13.43% <33.33%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Business.update_corp_state(cursor=cursor, event_id=filing.event_id, corp_num=corp_num)

# create new ledger text for annual report
ledger_year = agm_date if agm_date else f'NO AGM HELD IN {agm_year}'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not required. agm_date is required in COOP and we don't ask for CORPS

@vysakh-menon-aot vysakh-menon-aot merged commit 08ad5de into bcgov:main Aug 14, 2025
5 of 6 checks passed
@vysakh-menon-aot vysakh-menon-aot deleted the feature/29953 branch August 14, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants