30654 - officers spec #3786
30654 - officers spec #3786
Conversation
| summary: Change Of Officers Request | ||
| value: | ||
| filing: | ||
| header: |
There was a problem hiding this comment.
i noticed in the postman collection there type = "NON_LEGAL".
does the api user actually need to provide that in the request?
There was a problem hiding this comment.
It isn't required to pass validation but the api user will need to add this to include it in the submission.
There was a problem hiding this comment.
maybe we should consider setting this in the backend instead?
There was a problem hiding this comment.
So it sounds like this is required field for the COO filing.
If that really is the case, then I think we need to make sure the filing header spec includes "type" definition and the COO request/response examples will need to include type
And outside of this PR, I think we need to update the COO business api validator to check that the type property is passed into the filing header json and that the value is "NON_LEGAL"
There was a problem hiding this comment.
as per our conversation, we won't be needing api user to pass type in the filing header during submission of COO
|
looks good, just the two comments |
2 participants
Issue #: bcgov/entity#30654
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).