30698 Fix flag import in DBC utils #3792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas <lucasoneil@gmail.com>
Signed-off-by: Lucas <lucasoneil@gmail.com>
loneil
force-pushed
the
bugfix/dbcUtilsFlagImport
branch
from
fca7519 to
1704b90
Compare
loneil
commented
Sep 16, 2025
|
|
||
| test: ## Unit testing | ||
| . venv/bin/activate && pytest | ||
| . .venv/bin/activate && pytest |
Collaborator
Author
There was a problem hiding this comment.
Unrelated but this was changed to .venv in the run command a while back (commit) but not the test one.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes import issues in the digital credentials utils module by moving the flags import inside the function to avoid circular dependencies and updating test mocks accordingly.
- Moved flags import from module level to function level in
digital_credentials_utils.py - Updated test mocks to reference the correct import path
- Fixed virtual environment path in Makefile
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| digital_credentials_utils.py | Moved flags import inside function to avoid circular dependency |
| test_digital_credentials_helpers_and_utils.py | Updated test mocks to match new import path |
| Makefile | Updated virtual environment path from venv to .venv |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
Tests (relevant DC ones): 
|
argush3
approved these changes
Sep 17, 2025
severinbeauvais
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#30698
Description of changes:
Change flag import to get this working after recent flag changes. Locally when using LD SDK key I can now get the correct flag values. Could only get flags loading in this file that also imports current_app if I do the import in the function as done in some other example spots now...
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).