30861 API - business account settings #3822
Conversation
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
| 'businessIdentifier': self.business.identifier, | ||
| 'email': self.email, | ||
| 'phone': self.phone, | ||
| 'phoneExtension': self.phone_extension, |
There was a problem hiding this comment.
I just kept this flat, but was also thinking of putting 'email', 'phone', 'phoneExtension' inside a 'contact' field?
There was a problem hiding this comment.
I believe this is good, don't need contact field
| @jwt.requires_auth | ||
| def update_business_account_settings(account_id: str, identifier: str): | ||
| """Update the settings information for the business and account combination.""" | ||
| # TODO: decide if this is enough? Do we need to verify they are allowed to update the account? |
There was a problem hiding this comment.
Note - I think its okay not to have anything extra since we check that they have edit permissions on the business, but lmk what you think
There was a problem hiding this comment.
We need to include this into non-filing permissions, since this is a new permission you could create a separate ticket for this https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/services/permissions.py#L61. This permission is used in UI as well and i believe its feature flagged and disabled in PROD
There was a problem hiding this comment.
created a new ticket for this: bcgov/entity#30992
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
...business_model_migrations/versions/20251008_102501_015353fe5746_business_account_settings.py
Outdated
Show resolved
Hide resolved
python/common/business-registry-model/src/business_model/models/business_account_settings.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Kial Jinnah <kialj876@gmail.com>
legal-api/src/legal_api/resources/v2/business/business_account_settings.py
Show resolved
Hide resolved
severinbeauvais
changed the title
3 participants
Issue #: /bcgov/entity#30861
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).