30397 fix phone validation small clean #3827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| digits = digits[1:] | ||
| else: | ||
| return digits | ||
| return digits |
Collaborator
There was a problem hiding this comment.
What would happen before?
Contributor
Author
There was a problem hiding this comment.
If IF is true, it will not return the number 😂
Collaborator
There was a problem hiding this comment.
Yeah, so that was a bug.
Please add comments to the ticket that this situation needs to be verified (QAed).
severinbeauvais
approved these changes
Oct 8, 2025
Collaborator
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
LGTM but please wait for Vysakh's review.
vysakh-menon-aot
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#30397
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).