31256 Update AR spec with director/office note #3862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas <lucasoneil@gmail.com>
Collaborator
Author
|
Not sure which order of review/merge for these tasks so maybe will wait for any merge until developer.connect version wording is also approved. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the business.yaml API specification to add clarifying documentation notes for the Annual Report (AR) filing endpoints, specifically for the directors and offices fields based on user feedback from Discourse.
- Adds informative notes to the
directorsandofficesfields in the Annual Report schema - Clarifies that these fields are required for submission but not used to update information, only for review purposes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
argush3
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#31256
Description of changes:
This is the corresponding Lear
business.yamlchange to a developer.connect spec update here: bcgov/developer.connect#244Add a note to a couple AR fields defined from Discourse feedback (see linked issue). In developer.connect this renders as below:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).