Skip to content

Conversation

@vysakh-menon-aot
Copy link
Collaborator

Issue #: /bcgov/entity#31252

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 23.52941% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.66%. Comparing base (d995156) to head (642cb66).
⚠️ Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
colin-api/src/colin_api/models/filing.py 14.28% 6 Missing ⚠️
colin-api/src/colin_api/models/business.py 28.57% 5 Missing ⚠️
colin-api/src/colin_api/resources/filing.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3869   +/-   ##
=======================================
  Coverage   29.66%   29.66%           
=======================================
  Files          39       39           
  Lines        3486     3492    +6     
=======================================
+ Hits         1034     1036    +2     
- Misses       2452     2456    +4     
Flag Coverage Δ
colinapi 29.66% <23.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
colin-api/src/colin_api/resources/filing.py 23.31% <33.33%> (-0.15%) ⬇️
colin-api/src/colin_api/models/business.py 30.21% <28.57%> (-0.04%) ⬇️
colin-api/src/colin_api/models/filing.py 13.25% <14.28%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

# Freeze all entities except CP if business exists in lear and
# 'enable-bc-ccc-ulc' flag is on else just freeze BEN
is_frozen_condition = (
flags.is_on('enable-bc-ccc-ulc') and
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing this flag check in an assumption that we want to freezing all these types in colin (this flag check was introduced for directed launch)

@vysakh-menon-aot vysakh-menon-aot merged commit 5a8d2ed into bcgov:main Nov 28, 2025
6 checks passed
@vysakh-menon-aot vysakh-menon-aot deleted the feature/31252 branch November 28, 2025 19:30
Rajandeep98 pushed a commit to Rajandeep98/lear that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants