31203 - update version number for 27.6 #3912
Conversation
loneil
requested review from
Copilot,
ketaki-deodhar,
severinbeauvais and
vysakh-menon-aot
Signed-off-by: Lucas <lucasoneil@gmail.com>
loneil
force-pushed
the
chore/31203releaseVersion21610
branch
from
6104c40 to
59a545a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3912 +/- ##
=======================================
Coverage 29.66% 29.66%
=======================================
Files 39 39
Lines 3486 3492 +6
=======================================
+ Hits 1034 1036 +2
- Misses 2452 2456 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| """ | ||
|
|
||
| __version__ = '2.160.0' # pylint: disable=invalid-name | ||
| __version__ = '2.161.0' # pylint: disable=invalid-name |
There was a problem hiding this comment.
did colin actually have updates since the last release?
There was a problem hiding this comment.
No it didn't, would the practice be for the version num to match the release version from the parent Lear repo? Or should we just bump it if it's actually been changed?
There was a problem hiding this comment.
@loneil Was talking with Vysakh about how we want to deal with release versioning last Friday.
Before updating to use poetry, we were using version.py to track release versioning for our BE services. Before pushing to Test, we would only update the versioning for the BE services that had code changes.
I think moving forward we would like to follow what the FE is doing. That is whenever code updates are made we bump the version numbers in pyproject.toml and that saves us from having to update versioning numbers before pushing to Test. To make this happen, we still need to update the business api such that the /meta/info endpoint is pulling the versioning info from the toml file instead of versioning.py. The other queue services are already doing this I believe.
For this release, I think we can just stick to updating version numbers for affected components. i.e. remove colin versioning as there were no changes. But you can wait until tuesday to see which BE services are affected in the end.
There was a problem hiding this comment.
Sounds good thanks, yeah I'd noticed the 3.0.0 in the new pyproject for legal-api
There was a problem hiding this comment.
(moot in this case as the colin-api has been updated since, so keeping version bump)
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
LGTM but I'd hold on to this PR until you're ready to deploy to Test because there may be more changes between now and then.
Yeah Test just delayed until tuesday so I will put back in draft for now. |
3 participants
Issue #: /bcgov/entity#31203
Description of changes:
Bump version nums in
version.pyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).