31884 31888 sanitize address for BN messages #3984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loneil
approved these changes
Jan 20, 2026
Collaborator
loneil
left a comment
loneil
left a comment
There was a problem hiding this comment.
Looks good, good test coverage, just minor test suggestion
| from business_bn.bn_processors import sanitize_address | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("test_input, expected", [ |
Collaborator
There was a problem hiding this comment.
Could add inputs
- with whitespace on either side
- that have multiple (or all the) fields
just so the feilds list/lookup and strip parts are covered in case anyone changes that sanitize_address implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#31884, bcgov/entity#31888
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).