31921 - Dissolution Completing Party #3993
Conversation
Rajandeep98
changed the title
| document_optional_email = dissolution.get("filing", {}).get("header", {}).get("documentOptionalEmail") | ||
| if document_optional_email and account_id: | ||
| email_validation_result = validate_document_delivery_email_changed(document_optional_email, int(account_id)) |
There was a problem hiding this comment.
I am not sure about this validation, documentOptionalEmail is used to provide the user email if a staff is filing. Does the UI loads this value by default (and not editable)?
There was a problem hiding this comment.
its pre-populates as completingparty email then if edited goes in header as document optional email and users shows not editable prepopulated
There was a problem hiding this comment.
is it for staff or a user?
There was a problem hiding this comment.
this is for user for staff its editable, but that can be determined by if they have permission for edit completing party
legal-api/src/legal_api/services/filings/validations/dissolution.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
This PR adds completing party validation and permission checks for dissolution filings. It ensures that when completing party information is changed (email, name, or address), appropriate permissions are validated for SOLE_PROP and PARTNERSHIP business types.
Changes:
- Added completing party validation logic to dissolution filing validation
- Updated feature flag reference in good standing permission check
- Introduced new function to validate both permissions and completing party information
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| dissolution.py | Added completing party validation with permission checks for dissolution filings; created new function _validate_permission_and_completing_party to handle validation logic |
| common_validations.py | Updated feature flag name from "enable-list-actions-permissions" to "enabled-deeper-permission-action" and fixed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
legal-api/src/legal_api/services/filings/validations/dissolution.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/dissolution.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/dissolution.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/dissolution.py
Outdated
Show resolved
Hide resolved
|
Adding unit test |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
legal-api/src/legal_api/services/filings/validations/common_validations.py:1
- Dictionary formatting is inconsistent with spacing. Add a space after the colon for each key-value pair to follow Python style conventions (e.g.,
'check_name': True).
# Copyright © 2019 Province of British Columbia
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """Test suite to ensure Voluntary Dissolution is validated correctly.""" | ||
| import copy | ||
| from datetime import datetime, timedelta | ||
| from email.policy import default |
There was a problem hiding this comment.
The import from email.policy import default is unused in this file. This import should be removed as it serves no purpose and may cause confusion.
| from email.policy import default |
legal-api/src/legal_api/services/filings/validations/dissolution.py
Outdated
Show resolved
Hide resolved
legal-api/tests/unit/services/filings/validations/test_dissolution.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/common_validations.py
Outdated
Show resolved
Hide resolved
legal-api/tests/unit/services/filings/validations/test_dissolution.py
Outdated
Show resolved
Hide resolved
…tion.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…lidations.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tion.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…on.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
3 participants
Issue #: /bcgov/entity#31921
/bcgov/entity#31924
Description of changes:
Dissolution Completing Party Check
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).