31949 - Staff Filing Access limited #3997
Conversation
loneil
left a comment
loneil
left a comment
There was a problem hiding this comment.
Think it will do the trick but couple minor question/comment
| staff_filing_types = [ | ||
| CoreFiling.FilingTypes.AMALGAMATIONOUT.value, | ||
| CoreFiling.FilingTypes.CONTINUATIONOUT.value, | ||
| CoreFiling.FilingTypes.COURTORDER.value, | ||
| CoreFiling.FilingTypes.PUTBACKON.value, | ||
| CoreFiling.FilingTypes.PUTBACKOFF.value, | ||
| CoreFiling.FilingTypes.ADMIN_FREEZE.value, | ||
| CoreFiling.FilingTypes.REGISTRARSNOTATION.value, | ||
| CoreFiling.FilingTypes.REGISTRARSORDER.value | ||
| ] |
There was a problem hiding this comment.
Is there anything more global to the application already (maybe not?) than this local list for "what is a staff filing" that could be used?
| CoreFiling.FilingTypes.REGISTRARSORDER.value | ||
| ] | ||
|
|
||
| if filing_type in staff_filing_types: |
There was a problem hiding this comment.
Be good to add this additional logic to unit testing in test_permissions.py
| CoreFiling.FilingTypes.ADMIN_FREEZE.value, | ||
| CoreFiling.FilingTypes.REGISTRARSNOTATION.value, | ||
| CoreFiling.FilingTypes.REGISTRARSORDER.value | ||
| ] |
There was a problem hiding this comment.
missing changeOfLiquidators, changeOfReceivers, conversion, correction, dissolution (administrative)
There was a problem hiding this comment.
added, admin dissolution being controlled by its own dissolution permission being added to role (such as public only has voluntary dissolution)
severinbeauvais
left a comment
severinbeauvais
left a comment
There was a problem hiding this comment.
How does this PR solve the problem described in the ticket?
| CoreFiling.FilingTypes.CHANGEOFRECEIVERS.value, | ||
| CoreFiling.FilingTypes.CONVERSION.value, | ||
| CoreFiling.FilingTypes.CORRECTION.value | ||
| ] |
There was a problem hiding this comment.
Why is this being done separately from the other filings (eg, lines 153-196 below)?
The existing permissions mappings/tables should be able to handle staff filings types and staff permissions.
What the code above does is hard-code some of these mappings, which I think is a bad idea.
4 participants
Issue #: /bcgov/entity#31949
bcgov/entity#31918
bcgov/entity#31919
Description of changes:
Limit The Access to staff filings :
AMALGAMATIONOUT
CONTINUATIONOUT
COURTORDER
PUTBACKON
PUTBACKOFF
ADMIN_FREEZE
REGISTRARSNOTATION
REGISTRARSORDER
CHANGEOFLIQUIDATORS
CHANGEOFRECEIVERS
CONVERSION
CORRECTION
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).