31922 Amalgamation Completing Party email #3999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds validation logic for completing party and document delivery email editing permissions in the amalgamation application filing process. The changes restrict users from editing the completing party email and document delivery email unless they have the required permissions.
Changes:
- Added permission validation for completing party email changes in amalgamation applications
- Added permission validation for document delivery email (documentOptionalEmail) changes
- Imported additional validation functions from common_validations module
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
legal-api/src/legal_api/services/filings/validations/amalgamation_application.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/amalgamation_application.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/amalgamation_application.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/amalgamation_application.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/amalgamation_application.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/amalgamation_application.py
Outdated
Show resolved
Hide resolved
legal-api/src/legal_api/services/filings/validations/amalgamation_application.py
Outdated
Show resolved
Hide resolved
vysakh-menon-aot
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#31922
Description of changes:
User Can Not edit completing party email
User can not edit document delivery email (completing party as well)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).