32113 - Business Address Change in change of registration filing #4018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vysakh-menon-aot
approved these changes
Jan 21, 2026
loneil
reviewed
Jan 21, 2026
| invalid_roles = set() | ||
| parties = filing["filing"][filing_type]["parties"] | ||
| if flags.is_on("enabled-deeper-permission-action"): | ||
| if flags.is_on("enabled-deeper-permission-action") and filing_type == "registration": |
Collaborator
There was a problem hiding this comment.
Can the constant in filing.py FilingTypes import here instead of hard code?
loneil
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#32113
Description of changes:
Using same validate function for validate party in registration and change of registration only blocking for permission in registration : adding filing type to condition
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).