32465 - NOA Delivery Address not Available if Optional Postal Code Country

[meawong]

Issue #: /bcgov/entity#32465

Description of changes:

• Remove postal code condition for versioned party delivery addresses to match logic for versioned party mailing addresses in party_revision_json

On Dev:

After:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[meawong]

@argush3 Vysakh noted that some of this logic was added as part of the data migration work in your PR: #3338 Does this postal code requirement need to stay in place for versioned party delivery addresses, or can we safely remove it?

Current logic (before my changes):

Party Type	Address Type	Postal Code Required?
Versioned Party	Delivery Address	Yes
Versioned Party	Mailing Address	No
Non-Versioned Party	Any Address	Yes

[argush3]

@argush3 Vysakh noted that some of this logic was added as part of the data migration work in your PR: #3338 Does this postal code requirement need to stay in place for versioned party delivery addresses, or can we safely remove it?

Current logic (before my changes):

Party Type Address Type Postal Code Required?
Versioned Party Delivery Address Yes
Versioned Party Mailing Address No
Non-Versioned Party Any Address Yes

@meawong I approved your PR just by looking at the code. But I just saw your comments here now. Hold off on merging. I'll review what I did previously for data migration and get back to you.

[argush3]

@meawong let's merge this and let me know when it's in Dev. I think we can pull up some of the corps or load some corps from legacy that meet this criteria and see if things work properly.