33070 - Fix Certified By Validation for Firms and Coops#4249
Merged
meawong merged 2 commits intobcgov:mainfrom Apr 8, 2026
Merged
33070 - Fix Certified By Validation for Firms and Coops#4249meawong merged 2 commits intobcgov:mainfrom
meawong merged 2 commits intobcgov:mainfrom
Conversation
loneil
reviewed
Apr 7, 2026
Collaborator
loneil
left a comment
loneil
left a comment
There was a problem hiding this comment.
One minor comment. Minor sonarqube warnings too (could remove returns in tests as it says)
|
loneil
approved these changes
Apr 7, 2026
ketaki-deodhar
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#33070
Description of changes:
certifiedByvalidation still does not apply for CORPScertifiedByvalidation for COOPS/FIRMS for the following filings:Example failing on dev:
Now:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).