32886 - SAF - add ability to filter businesses based on director mail…#4254
Merged
Rajandeep98 merged 3 commits intobcgov:mainfrom Apr 14, 2026
Merged
Conversation
…ing address attributes
meawong
approved these changes
Apr 9, 2026
argush3
reviewed
Apr 10, 2026
| cp.corp_num, | ||
| COUNT(*) AS dir_cnt, | ||
| COUNT(*) Filter ( | ||
| WHERE cp.mailing_addr_id IS NOT NULL |
Collaborator
There was a problem hiding this comment.
think we should filter out stub addresses too. believe the stub address always has an address id = 1 in the COLIN extract.
i.e. add AND cp.mailing_addr_id <> 1 to where clause
argush3
reviewed
Apr 10, 2026
| AND UPPER(TRIM(ma.province)) = 'BC' | ||
| ) AS dir_bc_mailing_cnt, | ||
| COUNT(*) Filter ( | ||
| WHERE cp.mailing_addr_id IS NOT NULL |
Collaborator
There was a problem hiding this comment.
same as comment above.
Add AND cp.mailing_addr_id <> 1 to where clause to exclude stub addresses
argush3
approved these changes
Apr 10, 2026
Collaborator
argush3
left a comment
argush3
left a comment
There was a problem hiding this comment.
pre-approving with assumption stub address comment is addressed
|
ketaki-deodhar
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing address attributes
Issue #: /bcgov/entity#32886
Description of changes:
We want to add two boolean columns to the update the mv_legacy_corps_data materialized view in the COLIN extract.
directors_within_bc - returns true for a business where all directors have a mailing address where province = bc
directors_within_ca - returns true for a business where all directors have a mailing address where country = ca
Tasks
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).