32920 - Update Filer to Process Directors Based on ID Instead of Name for LEAR Filings#4256
Conversation
meawong
changed the title
| for director in new_directors: | ||
| # add new diretor party role to the business | ||
| party = create_party(business_id=business.id, party_info=director) | ||
| party = create_party(business_id=business.id, party_info=director, create=False) |
There was a problem hiding this comment.
create=False is used to bypass checking for an existing matching party, this is used in flows where we are creating new directors (i.e. IA, Amalg, Registration) and should be the same for COD when we are appointing a new director
| director["officer"].get("prevLastName")) | ||
| if filing_rec.colin_event_ids: | ||
| # Colin path: retain name-based matching for now. | ||
| _update_director_using_name(director=director, business_id=business.id) |
There was a problem hiding this comment.
We don't maintain the director id from lear in colin and vice versa so keeping the existing logic for colin path (matching based on name) since there is no cross-reference for the id.
| update_director(director=current_director, new_info=director) | ||
| break | ||
| # Lear path: match by party ID instead of name | ||
| _update_director_using_party_id(director=director, business_id=business.id) |
There was a problem hiding this comment.
For lear-native filings, we can match by party ID instead of name.
argush3
left a comment
argush3
left a comment
There was a problem hiding this comment.
looks good. just the one comment.
|
3 participants
Issue #: /bcgov/entity#32920
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).