Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GCP 1Password-backed environment variable mapping for legal-api to avoid using the Cloud SQL Python Connector + pg8000 connection path and instead rely on explicit DB credentials and a Unix socket configuration.
Changes:
- Add
DATABASE_PASSWORD,DATABASE_PORT, andDATABASE_UNIX_SOCKETto the GCP vault env mapping. - Remove
CLOUDSQL_INSTANCE_CONNECTION_NAMEandDATABASE_OWNER_ROLEfrom the GCP vault env mapping.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity###
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).