32826 - Add authorizationReceived Validation for Corps (Excluding IA and VD)#4322
Conversation
| } | ||
|
|
||
| FILINGS_REQUIRING_AUTHORIZATION = { | ||
| CoreFiling.FilingTypes.AGMEXTENSION, |
There was a problem hiding this comment.
Will need to add IA and VD to this list once the certified-by work is complete for those filings. This PR can be merged independently of that remaining work.
| CoreFiling.FilingTypes.CONSENTCONTINUATIONOUT, | ||
| CoreFiling.FilingTypes.CONTINUATIONIN, | ||
| CoreFiling.FilingTypes.CONTINUATIONOUT, | ||
| CoreFiling.FilingTypes.CORRECTION, |
There was a problem hiding this comment.
Would this trigger the flag needed on the staff Correction filing?
There was a problem hiding this comment.
Yes, this will trigger for both CLIENT and STAFF Corrections.
| return msg # authorizationReceived is only required for corporations | ||
|
|
||
| if filing_type not in FILINGS_REQUIRING_AUTHORIZATION: | ||
| return msg # authorizationReceived is only required for non-staff filings |
There was a problem hiding this comment.
Potentially should update this comment because corrections are in FILINGS_REQUIRING_AUTHORIZATION which is a staff filing?
| (CoreFiling.FilingTypes.ANNUALREPORT, True), | ||
| (CoreFiling.FilingTypes.REGISTRARSORDER, False), # staff filing | ||
| (CoreFiling.FilingTypes.INCORPORATIONAPPLICATION, False), # not in FILINGS_REQUIRING_AUTHORIZATION | ||
| ]) |
There was a problem hiding this comment.
This is cool - I didn't know you could stack parametrize like this. I like how you split out the params here
|
4 participants
Issue #: /bcgov/entity#32826
Description of changes:
authorizationReceivedvalidation tocommon_validationsin applicable filings for CORPS only (relevant filings list covered across these three tickets: Create UI, FIlings UI and Create UI )Corp Example requiring
authorizationReceived(COD):Corp Example not requiring
authorizationReceived(Registrars Notation):COOP Example (never requires
authorizationReceived):By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).