33224: Clear out currency_additional when altering currency to valid type#4332
Merged
loneil merged 1 commit intoApr 28, 2026
Merged
Conversation
Signed-off-by: Lucas <lucasoneil@gmail.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates share class persistence/serialization to ensure currency_additional is cleared when the share class currency is set to a non-OTHER code, and exposes currencyAdditional in the versioned business details output.
Changes:
- Clear
ShareClass.currency_additionalin the SQLAlchemybefore_insert/before_updatelistener whencurrency != OTHER. - Add unit tests covering listener behavior for
currency_additionalhandling (insert scenarios). - Include
currencyAdditionalinshare_class_revision_jsonoutput (versioned business details).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| legal-api/src/legal_api/models/share_class.py | Enforces clearing currency_additional when currency is not OTHER. |
| legal-api/src/legal_api/services/business_details_version.py | Adds currencyAdditional to share class revision JSON output. |
| legal-api/tests/unit/models/test_share_class.py | Adds listener tests for clearing/preserving currency_additional. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kialj876
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#33224
Description of changes:
If there's an additional currency in a share and you fix from OTHER to a valid type, remove that additional.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).