33002 - Remove certified copy stamp from Letter of Consent#4352
Merged
Conversation
…ING-3 report type and add verification tests.
|
Collaborator
Author
Only the letterOfConsent has been applied to the new FILING-3 type, and it is now correctly generating PDFs without the "Certified Copy" watermark. |
mruff-aeq
changed the title
mruff-aeq
changed the title
meawong
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33002 : /bcgov/entity#33002
Description of changes:
The "Certified Copy" stamp is triggered when the code calls the Document Retrieval Service (DRS) using a URL that includes the
?certifiedCopy=truequery parameter. By creating the FILING-3 report type, we are able to adjust the logic to omit that specific query parameter from the URL forletterOfConsent, which prevents DRS from injecting the stamp into the PDF.For verification, implemented a parameterized unit test that enforces the correct URL structure is generated for each specific report type, so it is ensured that the
?certifiedCopy=truequery parameter is only applied toFILING, FILING-2, and NOA, and explicitly omitted forletterOfConsentusing FILING-3.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).