add ip type var due to mismatch in vpc usage across envs#4361
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new 1Password-sourced environment variable intended to control Cloud SQL Connector IP type per environment (public in prod vs private in lower envs) to work around current VPC configuration differences.
Changes:
- Add
DATABASE_IP_TYPEto multiplevaults.gcp.envfiles for services/jobs that connect tobusiness-db. - Standardize retrieving the IP type from 1Password (
op://database/$APP_ENV/business-db/DATABASE_IP_TYPE) across impacted deployments.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| queue_services/business-pay/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for Business Pay DB connectivity. |
| queue_services/business-filer/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for Business Filer DB connectivity. |
| queue_services/business-emailer/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for Business Emailer DB connectivity. |
| queue_services/business-digital-credentials/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for Digital Credentials DB connectivity. |
| queue_services/business-bn/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for Business BN DB connectivity. |
| legal-api/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for Legal API DB connectivity. |
| gcp-jobs/involuntary-dissolutions/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for this job’s DB connectivity. |
| gcp-jobs/filings-notebook-report/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE (but job code currently reads IP_TYPE). |
| gcp-jobs/entity-bn/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE (but notebook currently reads IP_TYPE). |
| gcp-jobs/email-reminder/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for this job’s DB connectivity. |
| gcp-jobs/bn-retry/devops/vaults.gcp.env | Adds DATABASE_IP_TYPE secret mapping for this job’s DB connectivity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bolyachevets
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity33349
Description of changes:
Business db in prod is not configured to use shared vpc (this needs to be addressed via db migration referenced in the linked ticket).
For now, need to make sure that IP TYPE used in prod is Public (while dev/test/sandbox is Private)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).