[MDS-6460] Minespace NoW application stage status info by asinn134 · Pull Request #3527 · bcgov/mds

asinn134 · 2025-05-08T01:03:56Z

Objective

In Minespace added page for user to view status of NoW application stages
Put status page behind new feature flag
Removed the extra text being shown in the CRR and PRR Core page
Moved the noticeOfWorkMocks file from Core directory to the Common directory
Also moved the noticeOfWorkActionCreator.spec file to the Common directory because the noticeOfWorkActionCreator file only exists there and not in Core. Also did so to fix test coverage issue.

Copilot

Pull Request Overview

This PR implements the Minespace NoW application stage status information, adding support for tracking and returning application progress details via new endpoints and updated UI state management.

Added a new field (application_progress) in the API response model for NoW applications.
Introduced new resources and updated action types/reducers for proponent-specific application details.
Updated mocks, interfaces, constants, and API endpoints to reflect the new application progress functionality.

Reviewed Changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
services/core-api/app/api/now_applications/response_models.py	Adds the application_progress field to the response model.
services/core-api/app/api/now_applications/resources/now_application_proponent_resource.py	Introduces a new resource for proponent application details including progress data.
services/core-api/app/api/now_applications/resources/now_application_list_proponent_resource.py	Updates list resource to include application progress for each application.
services/core-api/app/api/now_applications/namespace.py	Registers the new proponent resource under the proper route.
services/core-api/app/api/now_applications/models/now_application_progress.py	Adds a helper method to retrieve progress data by application id.
services/common/src/utils/featureFlag.ts	Introduces a new feature flag for application details view.
services/common/src/tests/mocks/dataMocks.tsx	Updates mocks to include application_progress data.
services/common/src/redux/*	Updates selectors, reducers, actions, and action creators to align with the new progress functionality.
services/common/src/interfaces/*	Adds interfaces for application stages and progress.
services/common/src/constants/*	Updates string constants, badge types, action types, and API endpoints to support the new feature.

Copilot · 2025-05-08T16:49:05Z

services/core-api/app/api/now_applications/models/now_application_progress.py

+
+    @classmethod
+    def find_by_id(cls, now_application_id):
+        return cls.query.filter_by(now_application_id=now_application_id).all()


The find_by_id method returns a list even when no records are found, so the 'if now_application_progress is None' check in the resource code will never be true. Consider returning a single record or updating the check to verify an empty list instead.

Suggested change

return cls.query.filter_by(now_application_id=now_application_id).all()

return cls.query.filter_by(now_application_id=now_application_id).first()

I kept the .all() and removed the if now_application_progress is None

Copilot · 2025-05-08T16:49:05Z

services/common/src/redux/actionCreators/noticeOfWorkActionCreator.js

+      return response;
+    })
+    .catch(() => dispatch(error(NetworkReducerTypes.GET_PROPONENT_NOTICE_OF_WORK_APPLICATION)))
+    .finally(() => dispatch(hideLoading));


The hideLoading action is dispatched without being invoked. Change it to dispatch(hideLoading()) to correctly invoke the action creator.

Suggested change

.finally(() => dispatch(hideLoading));

.finally(() => dispatch(hideLoading()));

This is fixed now

Copilot · 2025-05-08T16:49:06Z

services/common/src/constants/badgeStatusTypes.ts

+  noticeOfWorkStage: {
+    "In Progress": "warning",
+    Complete: "success",
+    "Not started": "default",


There is a case inconsistency with the status string; the constant is defined as 'Not Started' elsewhere. Use consistent casing to avoid mismatches in status mapping.

Suggested change

"Not started": "default",

"Not Started": "default",

This is fixed too now

asinn134 · 2025-05-08T22:47:41Z

services/core-web/src/components/mine/Reports/MineReportInfo.tsx

          initialValues={stateParams}
          mineReportType={mine_reports_type}
        />
-        {mine_reports_type}


Extra text that Sam saw in CRR and PRR page

asinn134 · 2025-05-08T22:48:31Z

services/core-web/src/tests/actionCreators/documentActionCreator.spec.js

 import * as API from "@/constants/API";
 import * as MOCK from "@mds/common/tests/mocks/dataMocks";
-import * as NOW_MOCK from "@/tests/mocks/noticeOfWorkMocks";
+import * as NOW_MOCK from "@mds/common/tests/mocks/noticeOfWorkMock";


There are around 50ish files in this PR that just changes the import path of the noticeOfWorkMock

taraepp · 2025-05-09T17:14:35Z

services/common/src/redux/actionCreators/noticeOfWorkActionCreator.spec.js

@@ -0,0 +1,733 @@
+import MockAdapter from "axios-mock-adapter";


is this a brand new file? How many TS errors come up if it's renamed to .ts? If it's manageable I'd be in favour of making it TS.

This is now changed to .ts, it ended up being just a few small changes.

taraepp · 2025-05-09T17:20:09Z

...es/core-api/tests/now_applications/resources/test_now_application_list_proponent_resource.py

+class TestApplicationProponentListResource:
+    """GET /mines/<string:mine_guid>/now-applications"""
+
+    def test_get_proponent_now_application_list_success(self, test_client, db_session, auth_headers):


I'm thinking an error scenario would be good to add for both resources tests.

Check for non existent guids and error scenario test have been added now

taraepp · 2025-05-09T17:28:00Z

services/minespace-web/src/constants/routes.ts

+  hashRoute: (nowApplicationGuid, activeTab = "overview", link) =>
+    `/notice-of-work/${nowApplicationGuid}/${activeTab}/${link}`,
+  component: NoticeOfWorkPage,
+  helpKey: "View-Proponent-Notice-Of-Work",


I'd take out "Proponent" from here, just because it shows up in the help title and is kind of redundant on MS.

This has been removed from the help key now.

taraepp · 2025-05-09T17:39:51Z

services/minespace-web/src/components/pages/NoticeOfWork/NoticeOfWorkStagesTable.tsx

+    }));
+  const columns: ColumnsType<any> = [
+    {
+      title: <b>Stage</b>,


I was wondering why these are styled individually but then I looked at the mockups!
Hmm, just looking at some of Denise's other mockups, they also have bold table headers, and I think it's actually a nice change.
In the goal of keeping styling somewhat consistent, I'd recommend taking the <b>s out and adding font-weight to the .ant-table-thead>tr>th selector. I'm seeing that the line-height, colour, and border also changed, and so did the little divider between each column... Might even be out of scope.

That makes a lot of sense, thanks! I removed the <b> and added the font-weight style to that particular class. I left the other styling alone for now.

sonarqubecloud · 2025-05-09T18:56:29Z

Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-05-09T18:57:12Z

Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
51.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

asinn134 · 2025-05-09T18:58:53Z

services/minespace-web/src/components/pages/NoticeOfWork/NoticeOfWorkPage.tsx

+    ]).then(() => setIsLoaded(true));
+  };
+
+  const handleTabChange = (newActiveTab) => {


Removed the switch in the handleTabChange function here

sonarqubecloud · 2025-05-09T19:00:32Z

Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2025-05-09T19:02:35Z

Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

taraepp

🎨

matbusby-fw · 2025-05-09T23:08:37Z

services/minespace-web/src/components/dashboard/mine/projects/NoticeOfWorkTable.tsx

+            dataIndex: "project",
+            render: (text, record) => {
+              return (
+                <div title="">


Is there a reason for the empty title here?

asinn134 added 4 commits May 7, 2025 17:31

add display of NoW application stages statuses in minespace

bd9808e

Merge branch 'develop' into mds-6460-ms-now-application-status-page

1a08144

merge with develop branch

454ee68

remove commented code

23af8ba

asinn134 requested review from matbusby-fw, sggerard, simensma-fresh and taraepp May 8, 2025 16:39

asinn134 added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label May 8, 2025

sggerard requested a review from Copilot May 8, 2025 16:48

Copilot AI reviewed May 8, 2025

View reviewed changes

asinn134 added 2 commits May 8, 2025 14:32

attempt to fix test, and addressing some pr comments

fd8dd40

moving noticeOfWorkActionCreator tests and NoW mocks to common dir

e29c47a

asinn134 commented May 8, 2025

View reviewed changes

Merge branch 'develop' into mds-6460-ms-now-application-status-page

cc36d0a

taraepp reviewed May 9, 2025

View reviewed changes

addressing pr comments

51d533d

asinn134 commented May 9, 2025

View reviewed changes

asinn134 requested a review from taraepp May 9, 2025 19:12

taraepp approved these changes May 9, 2025

View reviewed changes

matbusby-fw reviewed May 9, 2025

View reviewed changes

matbusby-fw approved these changes May 9, 2025

View reviewed changes

asinn134 merged commit 80586b8 into develop May 9, 2025
19 of 20 checks passed

asinn134 deleted the mds-6460-ms-now-application-status-page branch May 9, 2025 23:15

	return cls.query.filter_by(now_application_id=now_application_id).all()
	return cls.query.filter_by(now_application_id=now_application_id).first()

	.finally(() => dispatch(hideLoading));
	.finally(() => dispatch(hideLoading()));

		@@ -0,0 +1,733 @@
		import MockAdapter from "axios-mock-adapter";

Conversation

asinn134 commented May 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asinn134 May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 9, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Uh oh!

sonarqubecloud bot commented May 9, 2025

Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Uh oh!

asinn134 May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 9, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Uh oh!

sonarqubecloud bot commented May 9, 2025

Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Uh oh!

taraepp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asinn134 commented May 8, 2025 •

edited

Loading

asinn134 May 9, 2025 •

edited

Loading

asinn134 May 9, 2025 •

edited

Loading