Conversation
|
|
sggerard
added
the
👍 Ready for review
taraepp
approved these changes
May 14, 2025
simensma-fresh
approved these changes
May 14, 2025
asinn134
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6491
The permit_conditions_bulk_export already supported NOW permits without any additional modifications. The only additional changes have been to add a permit_type field that is facetable and filterable.
There is a bug that was identified as part of this work with filters using the 'in' operator and haystack.
I have submitted a PR to haystack to address this, but until approved this will prevent some of the filters from returning any results when selected. deepset-ai/haystack-core-integrations#1729
The search index and indexer have been rebuilt, and some new data has been added from my local environment, however I have not exported and re-indexed the existing data so for testing you should use these permits:
Q-100000002:
C-1234: