Merged
Conversation
|
taraepp
approved these changes
May 22, 2025
matbusby-fw
reviewed
May 22, 2025
matbusby-fw
reviewed
May 22, 2025
services/core-api/app/api/now_applications/models/now_application_identity.py
Show resolved
Hide resolved
matbusby-fw
requested changes
May 22, 2025
Collaborator
matbusby-fw
left a comment
matbusby-fw
left a comment
There was a problem hiding this comment.
Looks awesome! Just a couple of minor things. Moving the sql likely doesn't matter too much, but I think it would be good to show the status name in the user error rather than the code.
asinn134
approved these changes
May 22, 2025
matbusby-fw
approved these changes
May 22, 2025
matbusby-fw
pushed a commit
that referenced
this pull request
May 26, 2025
* Support transferring draft permits, add migration * Update migration * Fix final bugs * Add test
asinn134
added a commit
that referenced
this pull request
May 29, 2025
* some missing env variables from local setup * [MDS-6451] Report Condition Migration (#3502) * create migration * drop the old column, add the unique constraint * fix unique constraint * change name of table, add audit fields * add deleted_ind to table * version history * fix null value insertion into guid column * get some of the tests working * update logic * changes in extraction process for tests * basic tests working for permit requirements * make error output stop running into a type error * remainder of tests * update error handling a bit * some missing env variables from local setup * [MDS-6451] Report Condition Migration (#3502) * create migration * drop the old column, add the unique constraint * fix unique constraint * change name of table, add audit fields * add deleted_ind to table * version history * fix null value insertion into guid column * get some of the tests working * update logic * changes in extraction process for tests * basic tests working for permit requirements * make error output stop running into a type error * remainder of tests * update error handling a bit * [MDS-6474] Report 1-many UI (#3535) * allow linking and unlinking of multiple conditions to report requirements. Do some cleanup * form changes * rest of the UI and also some BE stuff * test issues, styling issues * add a little BE test * fix some logic, update a test * selector test * test bad request * test coverage for get check permit id * remove stray "s" * update error message * change some field labels, error messge * allow linking and unlinking of multiple conditions to report req * checking out memory usage * revert memory monitoring * change title back too * [FIX] flagsmith error handling (#3537) don't crash BE when no app context when flagsmith is down * [MDS-6497] Fix for mine showing alerts from another mine (#3539) fix for mine showing alerts from another mine * [MDS-6491] Add permit_type tag (#3540) * Add permit_type meta tag * Update tests * Add output_dir * [Snyk] Security upgrade node from 20.18.3-alpine to 20.19.2-alpine (#3541) fix: services/minespace-web/Dockerfile.ci to reduce vulnerabilities Co-authored-by: snyk-bot <snyk-bot@snyk.io> * [MDS-6507] Fix for Page not found when clicking view minespace in Core (#3542) adjusted VIEW_MINESPACE route * [MDS-6062] Fix NOW transfer (#3543) * Support transferring draft permits, add migration * Update migration * Fix final bugs * Add test * some missing env variables from local setup * Handle duplicate report requirements in permit condition creation * adding report name when missing during permit extraction * adding report name when missing during permit extraction * some missing env variables from local setup * [MDS-6451] Report Condition Migration (#3502) * create migration * drop the old column, add the unique constraint * fix unique constraint * change name of table, add audit fields * add deleted_ind to table * version history * fix null value insertion into guid column * get some of the tests working * update logic * changes in extraction process for tests * basic tests working for permit requirements * make error output stop running into a type error * remainder of tests * update error handling a bit * [MDS-6474] Report 1-many UI (#3535) * allow linking and unlinking of multiple conditions to report requirements. Do some cleanup * form changes * rest of the UI and also some BE stuff * test issues, styling issues * add a little BE test * fix some logic, update a test * selector test * test bad request * test coverage for get check permit id * remove stray "s" * update error message * change some field labels, error messge * allow linking and unlinking of multiple conditions to report req * checking out memory usage * revert memory monitoring * change title back too * restore setenv to match dev * some missing env variables from local setup * Handle duplicate report requirements in permit condition creation * Refactor tests and logic for permit condition reports Added new test cases and improved existing ones for creating permit condition report requirements. Updated logic to handle session validation more robustly and ensure accurate processing of shared report requirements. * restore setenv to match dev * update test * adding report name when missing during permit extraction * update test * adding report name when missing during permit extraction * to match dev * remove space changes * add test * adding report name when missing during permit extraction * to match dev * remove space changes * add test * revert snap --------- Co-authored-by: Tara Epp <102187683+taraepp@users.noreply.github.com> Co-authored-by: Samuel Gerard <sggerard1997@gmail.com> Co-authored-by: Simen Fivelstad Smaaberg <66635118+simensma-fresh@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Mat.Busby <mat.busby@ca.ey.com>
taraepp
added a commit
that referenced
this pull request
Jun 4, 2025
* some missing env variables from local setup * [MDS-6451] Report Condition Migration (#3502) * create migration * drop the old column, add the unique constraint * fix unique constraint * change name of table, add audit fields * add deleted_ind to table * version history * fix null value insertion into guid column * get some of the tests working * update logic * changes in extraction process for tests * basic tests working for permit requirements * make error output stop running into a type error * remainder of tests * update error handling a bit * [MDS-6474] Report 1-many UI (#3535) * allow linking and unlinking of multiple conditions to report requirements. Do some cleanup * form changes * rest of the UI and also some BE stuff * test issues, styling issues * add a little BE test * fix some logic, update a test * selector test * test bad request * test coverage for get check permit id * remove stray "s" * update error message * change some field labels, error messge * allow linking and unlinking of multiple conditions to report req * checking out memory usage * revert memory monitoring * change title back too * restore setenv to match dev * [MDS-6450] identify same report (#3547) * some missing env variables from local setup * Handle duplicate report requirements in permit condition creation * Refactor tests and logic for permit condition reports Added new test cases and improved existing ones for creating permit condition report requirements. Updated logic to handle session validation more robustly and ensure accurate processing of shared report requirements. * restore setenv to match dev * update test * update test --------- Co-authored-by: Tara Epp <102187683+taraepp@users.noreply.github.com> * [MDS-6516] Add mandatory report name in extraction (#3551) * some missing env variables from local setup * [MDS-6451] Report Condition Migration (#3502) * create migration * drop the old column, add the unique constraint * fix unique constraint * change name of table, add audit fields * add deleted_ind to table * version history * fix null value insertion into guid column * get some of the tests working * update logic * changes in extraction process for tests * basic tests working for permit requirements * make error output stop running into a type error * remainder of tests * update error handling a bit * some missing env variables from local setup * [MDS-6451] Report Condition Migration (#3502) * create migration * drop the old column, add the unique constraint * fix unique constraint * change name of table, add audit fields * add deleted_ind to table * version history * fix null value insertion into guid column * get some of the tests working * update logic * changes in extraction process for tests * basic tests working for permit requirements * make error output stop running into a type error * remainder of tests * update error handling a bit * [MDS-6474] Report 1-many UI (#3535) * allow linking and unlinking of multiple conditions to report requirements. Do some cleanup * form changes * rest of the UI and also some BE stuff * test issues, styling issues * add a little BE test * fix some logic, update a test * selector test * test bad request * test coverage for get check permit id * remove stray "s" * update error message * change some field labels, error messge * allow linking and unlinking of multiple conditions to report req * checking out memory usage * revert memory monitoring * change title back too * [FIX] flagsmith error handling (#3537) don't crash BE when no app context when flagsmith is down * [MDS-6497] Fix for mine showing alerts from another mine (#3539) fix for mine showing alerts from another mine * [MDS-6491] Add permit_type tag (#3540) * Add permit_type meta tag * Update tests * Add output_dir * [Snyk] Security upgrade node from 20.18.3-alpine to 20.19.2-alpine (#3541) fix: services/minespace-web/Dockerfile.ci to reduce vulnerabilities Co-authored-by: snyk-bot <snyk-bot@snyk.io> * [MDS-6507] Fix for Page not found when clicking view minespace in Core (#3542) adjusted VIEW_MINESPACE route * [MDS-6062] Fix NOW transfer (#3543) * Support transferring draft permits, add migration * Update migration * Fix final bugs * Add test * some missing env variables from local setup * Handle duplicate report requirements in permit condition creation * adding report name when missing during permit extraction * adding report name when missing during permit extraction * some missing env variables from local setup * [MDS-6451] Report Condition Migration (#3502) * create migration * drop the old column, add the unique constraint * fix unique constraint * change name of table, add audit fields * add deleted_ind to table * version history * fix null value insertion into guid column * get some of the tests working * update logic * changes in extraction process for tests * basic tests working for permit requirements * make error output stop running into a type error * remainder of tests * update error handling a bit * [MDS-6474] Report 1-many UI (#3535) * allow linking and unlinking of multiple conditions to report requirements. Do some cleanup * form changes * rest of the UI and also some BE stuff * test issues, styling issues * add a little BE test * fix some logic, update a test * selector test * test bad request * test coverage for get check permit id * remove stray "s" * update error message * change some field labels, error messge * allow linking and unlinking of multiple conditions to report req * checking out memory usage * revert memory monitoring * change title back too * restore setenv to match dev * some missing env variables from local setup * Handle duplicate report requirements in permit condition creation * Refactor tests and logic for permit condition reports Added new test cases and improved existing ones for creating permit condition report requirements. Updated logic to handle session validation more robustly and ensure accurate processing of shared report requirements. * restore setenv to match dev * update test * adding report name when missing during permit extraction * update test * adding report name when missing during permit extraction * to match dev * remove space changes * add test * adding report name when missing during permit extraction * to match dev * remove space changes * add test * revert snap --------- Co-authored-by: Tara Epp <102187683+taraepp@users.noreply.github.com> Co-authored-by: Samuel Gerard <sggerard1997@gmail.com> Co-authored-by: Simen Fivelstad Smaaberg <66635118+simensma-fresh@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Mat.Busby <mat.busby@ca.ey.com> * address SonarQube reliability concern --------- Co-authored-by: Mat.Busby <mat.busby@ca.ey.com> Co-authored-by: Mat Busby <83598933+matbusby-fw@users.noreply.github.com> Co-authored-by: asinn134 <127789479+asinn134@users.noreply.github.com> Co-authored-by: Samuel Gerard <sggerard1997@gmail.com> Co-authored-by: Simen Fivelstad Smaaberg <66635118+simensma-fresh@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix transferring a Notice of Work between mines where a Draft permit has already been created
MDS-6062